Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kernelPackages scope for nvidia-display-driver callPackage #271

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

hacker1024
Copy link
Contributor

Description of changes

The nvidia-display-manager is not actually callPackaged from the kernelPackages scope, meaning that changes to packages within the scope (like the kernel itself) are not used in the nvidia-display-manager derivation.

In particular, this means that when using options like boot.kernelPatches, nvidia-display-manager erroneously still references the stock kernel, leading to two kernels being built.

This MR fixes this.

Testing

@danielfullmer
Copy link
Collaborator

Good catch! Thank you!

@danielfullmer danielfullmer merged commit 5db499e into anduril:master Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants