heavily refactor everything #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks nice! The static types are a nice addition. I suggest just publishing it and then I can link to it for people who would like a different style. Actually it relates precisely to my point here: http://www.oilshell.org/blog/2016/11/05.html So I can link to your fork there. I don't think I will modify this code again so it makes sense to have two separate copies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not suggesting you merge this, just though you might find it interesting :-)
I really liked the core of your code, but thought I'd have a go at translating into my style, I'm probably going to use a modified version in a personal project if that's all cool?
Thanks for the great work!