docs: generate adev-compatible api json #30857
Conversation
mmalerba
force-pushed
the
cdk-api
branch
4 times, most recently
from
0c6a191 to
50e19f9
Compare
mmalerba
changed the title
mmalerba
requested review from
crisbeto,
wagnermaciel and
andrewseguin
and removed request for
a team,
crisbeto and
wagnermaciel
mmalerba
force-pushed
the
cdk-api
branch
2 times, most recently
from
dc03d7b to
de4f33a
Compare
josephperrott
force-pushed
the
cdk-api
branch
3 times, most recently
from
a0aa103 to
82f26cf
Compare
| @@ -0,0 +1,70 @@ | |||
| load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary") | |||
There was a problem hiding this comment.
Can you use js_binary? nodejs_binary is the old one and doesn't support ESM
There was a problem hiding this comment.
I gave this a try, and it tells me that I have to run the js_binary with js_run_binary and that seems to be a whole can of worms that involves converting extract_api_to_json from a rule to a macro. And that probably entails changing the format of the parameters passed into the actual script.
This is all just copy/pasted from the fw repo with the idea that I would make minimal changes to it and it would eventually be refactored to just call the same script from some shared location.
There was a problem hiding this comment.
You should be able to just call the js_binary like the nodejs_binary. You just need to set BAZEL_BINDIR as environment variable.
I don't think, even if it's for copy/pasting, that we should introduce new instances of legacy code that we were removing/replacing in the last weeks/month.
| # Pass the import path map | ||
| # TODO: consider module_mappings_aspect to deal with path mappings instead of manually | ||
| # specifying them | ||
| # https://github.com/bazelbuild/rules_nodejs/blob/5.x/internal/linker/link_node_modules.bzl#L236 |
There was a problem hiding this comment.
Nit: update this TODO. With our new Bazel toolchain, this whole concept no longer exists (probably module_name attributes still need to be cleaned up though).
This way seems correct, but even better would be just leveraging the real tsconfig from src/bazel-tsconfig-build with the "real path mappings".
Currently using copied in script from adev, need to move the script to a shared location