Add units to ElectricCurrentGradient, PressureChangeRate #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, that tests worked here and shouldn't be from my changes? |
|
@vKaras1337 Thanks, this looks like a bunch of great work. Will review shortly. Broken tests and whitespace were existing issues due to some recent work. I'll look at it. Whitespace fixed: |
|
@vKaras1337 I think the broken tests are fixed now |
As Bar is commonly used for hydraulics and I could really use it to display pressure changes in our 'normal' unit. I don't know any russian, but i copy&pasted the abbreviations from the other units, verification needed? Added 'Milli' to AmperePerSecond and added AmperePerMinute with 'Milli' to ElectricCurrentGradient to display some slower and minor changes in current. Added the missing BaseUnits in AmperePerSecond and enabled SupportSIUnitSystem in the tests. I hope that is Ok? (As it uses Ampere and Second it should as of my understanding of UnitsNet)
…eGen change? can't find it because it looks like that this line changes has been excluded from commits from atleast (angularsen#656)
…rrent and PressureChangeRate and Time to Pressure
angularsen
force-pushed
the
add_PressureChange_bar_And_ElectricCurrentGradient_mA
branch
from
f233b51 to
cf1b16c
Compare
angularsen
changed the title
|
Nice job, looked perfect to me and a ton of new stuff. Nuget is out 👍 |
vKaras1337
deleted the
add_PressureChange_bar_And_ElectricCurrentGradient_mA
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I added some units witch we missed in our hydraulic use cases ;)
and did 2 small fixes? please look over these!
I hope I'm following all the guidelines correctly, if not please advice for changes ;)
Added Units
ElectricCurrentGradient:
PressureChangeRate:
Added operators
FIX
All generated files in
UnitsNet/GeneratedCode/Quanities/had a change of 1 spacechar.That's the change in
QuantityGenerator.cs.I set
SupportsSIUnitSystemtotrueinElectricCurrentGradientTestsand added theBaseUnitselement on AmperesPerSecond inElectricCurrentGradient.json.I think thats correct?
Addidionaly added some generated files that had a change of spaces in the <summary> tag.