fill=NA legend not working like fill=transparent #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdhock
requested changes
Oct 6, 2025
Contributor
Author
|
I have updated the NEWS.md file |
ANAMASGARD
force-pushed
the
fill=NA-legend-not-working
branch
from
62465d7 to
d334fd6
Compare
ANAMASGARD
force-pushed
the
fill=NA-legend-not-working
branch
from
d334fd6 to
219f037
Compare
tdhock
reviewed
Oct 8, 2025
tdhock
reviewed
Oct 8, 2025
tdhock
reviewed
Oct 8, 2025
Contributor
Author
|
https://github.com/animint/animint2/pull/244/commits I HAVE MADE ALL THE CHANGES YOU ASKED FOR , PLEASE GIVE YOUR FEEDBACK SIR . |
- Resolved NEWS.md conflict - Keep both version 2025.10.9 (PR#242) and 2025.10.5 (PR#244) entries
tdhock
reviewed
Oct 15, 2025
tdhock
changed the title
tdhock
approved these changes
Oct 22, 2025
Collaborator
|
great work! thanks very much |
tdhock
added a commit
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The
cleanData()function inR/z_animintHelpers.Rwas removing columns with NA values BEFORE convertingNAto"transparent", causing the fill column to be deleted.Solution
Reordered operations so that:
fill=NAtofill="transparent"usingtoRGB()FIRSTFiles Changed
R/z_animintHelpers.R- The fix (3 lines reordered)tests/testthat/test-compiler-legend-fill-na.R- New testsNEWS.md- Changelog entryTesting
pointfill: "transparent"now presentVisual Proof
Before: Left legend solid ❌
After: Both legends hollow ✅
Closes #227