Add linter to ensure no tabs in animint.js

[ANAMASGARD]

This PR adds two checks to prevent tabs from being introduced into inst/htmljs/animint.js:

1. GitHub Actions workflow (.github/workflows/check-tabs.yml) - Fails CI if tabs are detected
2. R test (tests/testthat/test-linter-no-tabs.R) - Tests during package checks

Testing

Tested locally by:

1. Verified no tabs in source:

   grep -P '\t' inst/htmljs/animint.js
   # No output - no tabs found ✓

2. Installed package and ran test (should pass):

   R CMD INSTALL .
   Rscript -e 'library(testthat); library(animint2); test_file("tests/testthat/test-linter-no-tabs.R")'
   # Result: PASS (2 tests passed) ✓

3. Added tab to line 10 and tested (should fail):

   R CMD INSTALL .
   Rscript -e 'library(testthat); library(animint2); test_file("tests/testthat/test-linter-no-tabs.R")'
   # Result: FAIL - "Tab characters found in animint.js at lines: 10" ✓

4. Removed tab and verified test passes again:
   The test correctly detects when tabs are present and passes when they're removed.

Files Changed

• .github/workflows/check-tabs.yml - New CI workflow
• tests/testthat/test-linter-no-tabs.R - New R test

Fixes #256

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.37%. Comparing base (efbe67b) to head (c756dd9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #257       +/-   ##
===========================================
+ Coverage   77.71%   95.37%   +17.65%     
===========================================
  Files         164        1      -163     
  Lines        8788     2788     -6000     
  Branches      562      574       +12     
===========================================
- Hits         6830     2659     -4171     
+ Misses       1958      129     -1829     

Flag	Coverage Δ
javascript	95.37% <ø> (ø)
r	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tdhock]

please add mustWork=TRUE

[ANAMASGARD]

Sir Thank a lot for the suggestion! I looked into using lintr as you recommended. However, lintr is specifically designed for linting R code, not JavaScript files.​

Since we're checking inst/htmljs/animint.js (a JavaScript file) for tabs, using lintr would require creating a complex custom linter that reads non-R files, which seems like overkill for this simple check.​

The current grep-based approach:-
1-) Works directly on the JavaScript file​.
2-) Requires no R dependencies​.
3-) Runs faster (no R setup needed)​.
4-) It is also easier to maintain​ .

Would you be okay with keeping the simple grep approach in .github/workflows/check-tabs.yml and removing the redundant R test file entirely as you mentioned ? This gives us the CI protection you want without unnecessary complexity.

The https://github.com/Rdatatable/data.table/blob/master/.github/workflows/code-quality.yaml
you mentioned kind of feels in my opinion overkill (as mentioned above) for checking of tabs in one single JavaScript file.
In Data.table workflow checks hundreds of R, C, markdown, and documentation files across an entire codebase.

Sir if you want to add some feedback or correct me if I am wrong in any way of my understanding.

[tdhock]

please avoid cross-posting (you wrote the same comment in #256 ).

can you please push a commit which adds a tab to animint.js, so we can see that the test would correctly fail in that case?
(and then push another commit which removes the tab)

[tdhock]

please remove test-linter-no-tabs.R

[ANAMASGARD]

Root cause: The test test-compiler-ghpages.R tries to DELETE a GitHub repository but lacks permissions:

❌ R_coverage fails due to pre-existing GitHub API permissions issue

Sir should I proceed with this PR as-is, or would you like me to investigate the ghpages test issue separately in a different PR?

[tdhock]

when there is a ghpages test failure that is typically a false positive, which we can ignore.
or even better, restart the build on the action page.

[tdhock]

great thanks