test for geom_point default shape 21 #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The Test has passed locally , fix is working . 
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
=======================================
Coverage 77.73% 77.73%
=======================================
Files 164 164
Lines 8788 8788
Branches 574 562 -12
=======================================
Hits 6831 6831
Misses 1957 1957
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
No obvious timing issues in HEAD=shape-21-default Generated via commit e246e96 Download link for the artifact containing the test results: ↓ atime-results.zip
|
tdhock
requested changes
Oct 27, 2025
Collaborator
tdhock
left a comment
tdhock
left a comment
There was a problem hiding this comment.
great thanks!
can you please increase version number in DESCRIPTION and add an item to NEWS?
Collaborator
|
great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268
This PR changes the default shape for
geom_pointfrom 19 to 21 to enable both color and fill aesthetics for more consistent static rendering.Changes:
Test output showing failure:
