Add linux-arm64 support #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshheinrichs-shopify
force-pushed
the
linux-arm64
branch
from
0822d47 to
a2b604f
Compare
ankane
reviewed
Jun 24, 2025
Owner
ankane
left a comment
ankane
left a comment
There was a problem hiding this comment.
Thanks @joshheinrichs-shopify, left a comment inline.
Rakefile
Outdated
|
|
||
| url = | ||
| if file == "lib_lightgbm.arm64.dylib" | ||
| if ["lib_lightgbm.so", "lib_lightgbm.arm64.so"].include?(file) |
Owner
There was a problem hiding this comment.
["lib_lightgbm.arm64.so", "lib_lightgbm.arm64.dylib"]
Contributor
Author
There was a problem hiding this comment.
oh god sorry 🤦
joshheinrichs-shopify
force-pushed
the
linux-arm64
branch
from
a2b604f to
5c20e7b
Compare
Owner
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on updating ml-builds to build lib_lightgbm.arm64.so ankane/ml-builds#4