Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: de-duplicate .csv/.tsv values both in IntentHandler and in ImportFileSelectionFragment #17875

Open
mikehardy opened this issue Jan 26, 2025 · 2 comments · May be fixed by #17887
Open

refactor: de-duplicate .csv/.tsv values both in IntentHandler and in ImportFileSelectionFragment #17875

mikehardy opened this issue Jan 26, 2025 · 2 comments · May be fixed by #17887
Assignees
@argon2r
Labels
Good First Issue!

Comments

@mikehardy
Copy link
Member

mikehardy commented Jan 26, 2025 •
edited
Loading

those values are both here and in ImportFileSelectionFragment, which makes easier to forget to add a value to some of them (this one doesn't have text/plain, but the other does).

Extracting the list to somewhere and reusing it in both places would be better IMO

Originally posted by @BrayanDSO in #17867 (comment)
@mikehardy mikehardy mentioned this issue Jan 26, 2025
Merged
5 tasks
@david-allison
Copy link
Member

david-allison commented Jan 26, 2025 •
edited
Loading

Thanks! Tagging as a good first issue. I'll take it on if it's not done this week (as agreed in the PR)

@argon2r
Copy link

argon2r commented Jan 26, 2025

Looking into it.

@argon2r argon2r linked a pull request Jan 27, 2025 that will close this issue
Open
5 tasks
@david-allison david-allison mentioned this issue Jan 29, 2025
Merged
5 tasks
@BrayanDSO BrayanDSO mentioned this issue Feb 5, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@argon2r argon2r

Labels
Good First Issue!
Projects
None yet
Milestone
No milestone
3 participants
@mikehardy @david-allison @argon2r