Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enable sharing .txt files for import in AnkiDroid #17874

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

SanjaySargam
Copy link
Contributor

Purpose / Description

This PR adds the necessary intent-filter configuration to the AndroidManifest.xml to enable AnkiDroid to handle .txt files shared from the file manager for import

Fixes

Approach

Added intent-filter for text/plain MIME type to support .txt file sharing and import

How Has This Been Tested?

Physical Device (Redmi Note 13)

WhatsApp.Video.2025-01-26.at.4.02.43.PM.mp4

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Jan 29, 2025
@SanjaySargam SanjaySargam added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Jan 29, 2025
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

AnkiDroid/src/main/AndroidManifest.xml Show resolved Hide resolved
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 29, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 3, 2025
@lukstbit lukstbit added this pull request to the merge queue Feb 3, 2025
Merged via the queue into ankidroid:main with commit f5b3d33 Feb 3, 2025
9 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 3, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Share Option for .txt Files while Importing
3 participants