Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card browser: Increase Height of Column Headers #17896

Open
brishtibheja opened this issue Jan 29, 2025 · 6 comments · May be fixed by #17904
Open

Card browser: Increase Height of Column Headers #17896

brishtibheja opened this issue Jan 29, 2025 · 6 comments · May be fixed by #17904

Comments

@brishtibheja
Copy link

In latest alpha, column headers' height are reduced which is a a11y issue. From David Allison:

I /prefer/ it to be the height, so we get more information on the screen, but we're breaking Google accessibility guidelines on this [touchable elements should be 48dp tall]

Suggest that we hide it on scroll down, as is done with something like the statistics page header

@BrayanDSO

This comment has been minimized.

@brishtibheja

This comment has been minimized.

@BrayanDSO

This comment has been minimized.

@BrayanDSO BrayanDSO changed the title Deck Options: Increase Height of Column Headers Card browser: Increase Height of Column Headers Jan 29, 2025
@brishtibheja

This comment has been minimized.

@argon2r
Copy link

argon2r commented Jan 30, 2025

Image
Is this the desired output? @brishtibheja

@brishtibheja
Copy link
Author

@argon2r I am not a maintainer for this project; ask this in #android-design in the discord server if u want more feedback before opening a PR. personally, LGTM.

@argon2r argon2r linked a pull request Jan 30, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants