Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve ControlPreference Style #17927

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Feb 7, 2025

The PR is mostly a refactor that generifies ControlPreference so it can be used in simple screens like the Previewer

but it also adds some icons to the control preference dialog to make it look better

How Has This Been Tested?

Emulator 35:

rev-style.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO added Needs Review Blocked by dependency Currently blocked by some other dependent / related change labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@BrayanDSO BrayanDSO force-pushed the controls-style branch 3 times, most recently from 5f22b6a to ae9f468 Compare February 9, 2025 17:49
@BrayanDSO BrayanDSO removed Blocked by dependency Currently blocked by some other dependent / related change Has Conflicts labels Feb 10, 2025
It is mostly a refactor because it generifies ControlPreference so it can be used in simple screens like the Previewer

but it also adds some icons to the control preference dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant