Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow fine tuning of the unbury action in congrats screen #17960

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat: Allow fine tuning of the unbury action in congrats screen #17960

merged 1 commit into from
Feb 10, 2025

Conversation

lukstbit
Copy link
Member

Purpose / Description

This PR introduces a dialog in CongratsPage with the options to execute a more granular unbury if possible.

See https://github.com/ankitects/anki/blob/acaeee91fa853e4a7a78dcddbb832d009ec3529a/qt/aqt/overview.py#L151-L174

The dialog(uses standard AlertDialogFacade.kt methods):

Screenshot from 2025-02-10 19-24-38

Fixes

Approach

How does this change address the problem?

How Has This Been Tested?

Ran the tests, manually tested the situation when the dialog needs to be shown to the user.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@lukstbit
Allow fine tuning the unbury action in congrats screen
c77e4ff 
Follows desktop code to present the user with a dialog to
select what to unbury based on the info returned for the
congrats screen.

See https://github.com/ankitects/anki/blob/acaeee91fa853e4a7a78dcddbb832d009ec3529a/qt/aqt/overview.py#L151-L174
david-allison
david-allison approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison david-allison changed the title Allow fine tuning of the unbury action in congrats screen feat: Allow fine tuning of the unbury action in congrats screen Feb 10, 2025
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 10, 2025
mikehardy
mikehardy approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@mikehardy mikehardy added this pull request to the merge queue Feb 10, 2025
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 10, 2025
Merged via the queue into ankidroid:main with commit c77e4ff Feb 10, 2025
20 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 10, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Feb 10, 2025
@lukstbit lukstbit deleted the feat_unburyFineTuning branch February 11, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@david-allison david-allison david-allison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.21 release
Development

Successfully merging this pull request may close these issues.

Enhancement: Allow Fine-tuning Unbury Action
3 participants
@lukstbit @mikehardy @david-allison