Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Deck Picker Arrow doesn't rotate on expanding and collapsing the deck. #17966

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

xenonnn4w
Copy link
Contributor

@xenonnn4w xenonnn4w commented Feb 12, 2025

Purpose / Description

In the deck picker, arrow doesn't rotate on expanding or collapsing the deck.

Fixes

Approach

deckExpander (the dropdown arrow) visibility and click behavior depend on node.children.isNotEmpty(). When the user toggles the expansion state (by clicking deckExpander), the dataset changes, but without notifyItemChanged(position), the UI does not get updated.

How Has This Been Tested?

API 24

android7.webm

API 34

androidapi35.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@xenonnn4w
Copy link
Contributor Author

While testing it, somehow i encountered that no deck expander is created for a deck. Maybe that due to runBlocking , but i'm unable to reproduce the same again.

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 12, 2025
@xenonnn4w xenonnn4w force-pushed the dropErr branch 2 times, most recently from 8b03e83 to 2e984ad Compare February 12, 2025 21:36
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 13, 2025
@lukstbit lukstbit added this pull request to the merge queue Feb 13, 2025
Merged via the queue into ankidroid:main with commit c5ecff9 Feb 13, 2025
9 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 13, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In deck picker, arrow doesn't rotate on expanding deck
2 participants