test: mark DeckPicker context menu test flaky on windows #17977
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrayanDSO
approved these changes
Feb 14, 2025
| import com.ichi2.testutils.grantWritePermissions | ||
| import com.ichi2.testutils.revokeWritePermissions | ||
| import com.ichi2.utils.KotlinCleanup | ||
| import com.ichi2.utils.ResourceLoader | ||
| import org.apache.commons.exec.OS |
There was a problem hiding this comment.
this was the only use of the dependency (libs.commons.exec on build.gradle). It probably can be removed now
BrayanDSO
added
Needs Author Reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue
This one is messing up my merge queue, driving me crazy.
Marking flaky
Had to de-conflict the "OS" symbol because something else appears to have been marked flaky, perhaps before we had a good annotation? Anyway, we have a good annotation now so I converted the previous windows cutout to a Flaky annotation