Skip to content

style(new reviewer): tweak margins #18732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Jul 1, 2025

Purpose / Description

Tweak some margin values

How has this been tested?

Emulator 35

Screenshot_20250701_055909
Screenshot_20250701_055953
Screenshot_20250701_060015
marg

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots?

My main 'padding' commentary is that the answer buttons could do with 1 or 2 dp more at the bottom: visually the padding on the bottom feels lower than at the top

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Jul 1, 2025
@BrayanDSO
Copy link
Member Author

BrayanDSO commented Jul 1, 2025

Screenshots?

Got lazy, sorry. Added the screenshots in the PR description.

visually the padding on the bottom feels lower than at the top

At the moment, they are technically symmetrical.

Screenshot from this PR

symmetr

I think it's possible to feel a difference depending on the display cutout and navigation bar style. Not sure how to solve that, or if I should try to solve.

@BrayanDSO BrayanDSO removed the Needs Author Reply Waiting for a reply from the original author label Jul 1, 2025
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 2, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 4, 2025
@BrayanDSO
Copy link
Member Author

Changes should be minor.

I'll merge this one to clean some conflicts I'll get later.

@BrayanDSO BrayanDSO added this pull request to the merge queue Jul 4, 2025
Merged via the queue into ankidroid:main with commit 2ca3fff Jul 4, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 4, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants