Compare LRO generated enumerator approach to branch with updated paging APIs #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt and having factory methods to different LRO types for convenience and streaming
… observe eht stream in that case
…ActionUpdate to make it a RunUpdate
In [System.ClientModel 1.1.0-beta.5](https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/System.ClientModel/CHANGELOG.md#110-beta5-2024-07-11), `PageableCollection<T>` was changed to `PageCollection<T>` to better align convenience and protocol methods. This PR upgrades the OpenAI library to SCM 1.1.0-beta.5, and manually implements internal types that will be generated from TypeSpec API specification in the future. Specifically, it: - Updates return types that have been renamed for streaming service methods - For service methods corresponding to paginated-collection endpoints - Returns `PageCollection<T>` or `AsyncPageCollection<T>` from convenience methods - Takes `XxCollectionOptions` types that describe the paginated collection to be returned - Adds "rehydration" methods that return a collection that starts where another collection type left off via a persisted rehydration token - Returns `IEnumerable<ClientResult>` or `IAsyncEnumerable<ClientResult>` from protocol methods, representing a collection of service responses, where each corresponds to a page of results returned from the paginated endpoint - Implements internal page enumerator and page token types for each paginated-endpoint operation Types that are intended to be output by the generator have been added in a temporary folder called `To.Be.Generated`.
…te enumerator instance until MoveNext is called
This PR updates the init to set. The API will be updated in the following PR.
… very close to the issue templates found in the other repos, like openai-python. (openai#146) Co-authored-by: Angelos Petropoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIView in progress.