-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type definition and structure proposal #1
base: main
Are you sure you want to change the base?
Conversation
I would not do auto discovery within a GitHub repository. 1 request per repository is already expensive enough. We currently have |
"There should be a single top-level json file with all the information." I'd like to keep backwards compatibility for my manager and this would require the possibility to add repos/packages not maintained anymore or even without modinfo.json. I could host the meta information in a separate fork of this repo but it would make sense to keep it all together. That's why i made .mods optional - this would create a way for old/unmaintained mods to be included as well (without any meta repo/forked trough "hackydêhack") |
The I'd use the same json for external mods as well and not create another |
Program journey:
and if I understood your package.json correct it would require each and every modder to change her/his current mod/pack to be compliant. This would result, in my opinion, in an incomplete index where we aren't able to list many mods (e.g. mostly mods where the creators aren't going to change "just to be listed" on a currently unknown platform) I'd understand if you or the imya team would like to follow the more strict approach (and require changes by creators/modders to be compliant) - in that case I'd need to branch of to get the user and creator -experiance I'm after. |
Add `residences-provide-influence`
@taubenangriff any thoughts? |
With mod.io upcoming, most of the "just works" concerns are out of the way I guess? Can add our mods here, but it's mostly just for lulz. mod.io will be the way to go forward. |
Fair enough. Then merge and deprecate the whole repo? Cleaning up is not a bad idea either. |
Why deprecate? still need it for imya I guess. If imya deletes the feature, we can close the repo though. But that's another discussion. |
Ah, I thought you meant the whole feature ;-) |
a package type to support non github based mods as well as source branch released ones
also an optional .mods where a list of mods contained inside the package.
e.g.
{
"Spice_Cameraflight":"https://raw.githubusercontent.com/anno-mods/Spice-it-Up/master/%5BAddon%5D%20Cape%20Trelawney%20Camera%20Flight/modinfo.Json"
}
this way mod (not only packages) could be checked for updates and it would be platform agnostic