fix(examples): prevent unnecessary IdP redirect when session is still valid#325
Open
MrHertal wants to merge 1 commit intoanomalyco:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
login()function in the examples checks for an existing valid session before redirecting to the IdP. However,client.verify()only populatesverified.tokenswhen a token refresh actually occurs — when the access token is still valid,tokensisundefined. The original condition!verified.err && verified.tokensevaluates tofalsefor valid (non-expired) sessions, causing the code to fall through toclient.authorize()and trigger an unnecessary full OAuth round-trip.The fix checks
!verified.erralone to determine session validity, and only callssetTokenswhenverified.tokensis present (i.e., a refresh occurred).Files changed
examples/quickstart/sst/app/actions.tsexamples/quickstart/standalone/app/actions.tsexamples/client/nextjs/app/actions.tswww/src/content/docs/docs/start/sst.mdxwww/src/content/docs/docs/start/standalone.mdxNote: the
auth()function in those same files already handled this correctly with separate checks. The bug only affectedlogin().