fix: don't ask for permission for cd within project #8190
+95
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8192.
Fixes false permission requests when chained
cdcommands navigate within the project directory. Previously, commands likecd subdir && do something && cd ..would incorrectly trigger anexternal_directorypermission request because all paths were resolved relative to the initial working directory rather than tracking the effective directory after eachcd.The fix tracks an
effectiveCwdvariable that updates after eachcdcommand, so subsequent path resolutions use the correct context.How did you verify your code works?
Added three tests in
test/tool/bash.test.ts:cd subdir && ls && cd ..does not request external_directory permissioncd a && cd b && cd c && cd .. && cd .. && cd ..(nested navigation) does not request permissioncd subdir && cd ../..(actually escapes project) still correctly requests permissionVerified tests fail before the fix and pass after.
WIP: Not all combinations of commands are
&&s, socdshouldn't always change the effective working directory of the next command. We should instead use the AST provided by the tree-sitter and track the working directory along its paths.