fix(tui): respect terminal transparency in system theme #8467
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set system theme background to transparent (RGBA with alpha=0) to allow terminal transparency settings (e.g., Ghostty background-opacity) to show through. Dialog panels and UI elements remain opaque with terminal-derived colors for readability. Changes: - Main background now fully transparent instead of using terminal background color - Dialog panels, elements, and menus keep opaque backgrounds for clarity Fixes anomalyco#4027
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set system theme background to transparent (RGBA with alpha=0) to allow terminal transparency settings (e.g., Ghostty background-opacity) to show through. Dialog panels and UI elements remain opaque with terminal-derived colors for readability.
Fixes #4027
The issue being open for so long and the fix being so simple makes me think I'm not aware of some other issue this may cause 🤔. I've checked #4369 but it's not an issue on my PR (see screenshots below)
How did you verify your code works?
Before/After