fix(tui): prevent accidental hover selection in autocomplete menus #8797
+129
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search results, no duplicate PRs were found. The only PR returned in all searches is the current PR #8797 itself. While PR #7967 appears in the results related to hover/click support in prompts, it addresses a different component (permission prompt) and is about adding mouse support rather than fixing accidental selection behavior. |
Track mouse movement using a global flag that resets when menus open or filter text changes. Selection only activates when the cursor has moved, preventing accidental selection when: - Menu appears under a stationary cursor - Filter changes reorder items under a stationary cursor The flag is set on first mouse movement and immediately selects the item at that moment, allowing responsive hover selection while blocking initial accidental selection. Terminal layer naturally filters out 1-2px jitter, providing built-in tremor tolerance.
JosXa
force-pushed
the
fix-mouse-hover
branch
from
7945a40 to
9e2c1ae
Compare
Contributor
Author
Thanks, done: #8799 |
Collaborator
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem 🔽
Autocomplete menus (
@and/in TUI) and dialog select components currently auto-select items when UI elements move under a stationary cursor. This creates two problematic scenarios:Users expect hover selection to activate only on intentional mouse movement, not when UI elements move under a stationary cursor.
mouse-highlight-bug.mp4
Solution 🔽
WindowsTerminal_zlB4E0m0KW.mp4
Just checked, and it's fixed in the menu aswell:
WindowsTerminal_TTu0nLAE43.mp4
The fix tracks actual mouse movement to distinguish between:
This is implemented by:
hasMouseMovedflag tofalsewhen menus open or filter text changesmousemoveevents to set the flag totruehasMouseMoved === trueComponents updated:
Select.tsx: Dialog select menusChatInput.tsx: Autocomplete menus (@and/)This ensures hover selection only activates on deliberate user action, making keyboard navigation reliable and preventing surprising auto-selections.
Closes #8799