Skip to content

Conversation

@oraNod
Copy link
Contributor

@oraNod oraNod commented Sep 30, 2025

Yikes! We need our custom 404 cowsay added to the landing pages. This PR does that, even though it's not perfect (see the README).

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the generated RTD site and LGTM, thanks!

Notes in readme make sense.

@oraNod oraNod marked this pull request as draft October 6, 2025 07:41
@oraNod oraNod marked this pull request as ready for review October 13, 2025 20:25
@oraNod oraNod requested a review from felixfontein October 13, 2025 20:25
@oraNod
Copy link
Contributor Author

oraNod commented Oct 13, 2025

Thanks again for the pointer to the errorpages plugin @felixfontein (and thanks for writing it). Please note that I changed the nikola config so that URL_TYPE = 'absolute'

I think this is a config that we'll want anyway. I was thinking about doing that later so that references include the full domain, which is good for SEO.

However it means that the cowsay image won't show up in the RTD preview build. It's a chicken / egg scenario because this PR adds the cowsay.

@oraNod oraNod merged commit fa8c265 into ansible-community:main Oct 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants