Lint the results from role generation #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabashian
force-pushed
the
mabashian/AAP-37200
branch
from
09cde98 to
0251a4c
Compare
mabashian
force-pushed
the
mabashian/AAP-37200
branch
from
0251a4c to
e3a0106
Compare
goneri
reviewed
Feb 3, 2025
| @@ -507,7 +512,70 @@ def __init__(self, config: WCA_PIPELINE_CONFIGURATION): | |||
| super().__init__(config=config) | |||
|
|
|||
| def invoke(self, params: RoleGenerationParameters) -> RoleGenerationResponse: | |||
| raise NotImplementedError | |||
| request = params.request | |||
There was a problem hiding this comment.
I believe this should only be implemented in pipelines_saas.py since we don't want to provide this feature yet with the onPrem offert. @manstis WDYT?
There was a problem hiding this comment.
@goneri @mabashian Yes, if this is only available for SaaS then that would be a better place for it. However please put a comment saying it should be moved back to the base WCA class when it becomes available for on-prem 😁 (otherwise we'll either have to remember or risk the duplication).
There was a problem hiding this comment.
(I was going to review this PR tomorrow)
mabashian
force-pushed
the
mabashian/AAP-37200
branch
from
3b9e74b to
14c441f
Compare
|
goneri
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: https://issues.redhat.com/browse/AAP-37200
Description
This PR does two things:
Testing
Unit test coverage added for new scenarios
Scenarios tested
None beyond the automated tests
Production deployment