settings: add the ANSIBLE_AI_ENABLE_ROLE_GEN_ENDPOINT config key #1529
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manstis
previously approved these changes
Feb 12, 2025
| @@ -363,6 +363,9 @@ def invoke(self, params: RoleGenerationParameters) -> RoleGenerationResponse: | |||
| if outline: | |||
| data["outline"] = outline | |||
|
|
|||
| if not settings.ANSIBLE_AI_ENABLE_ROLE_GEN_ENDPOINT: | |||
There was a problem hiding this comment.
IDK if it'd be clearer to move this closer to the start of the function?
e.g.
The function performs some (potentially expensive) operations that are thrown away if not enabled.
Add `ANSIBLE_AI_ENABLE_ROLE_GEN_ENDPOINT` to be able to enable roleGen when needed. This will later be enabled by default.
goneri
force-pushed
the
goneri/settings-add-the-ANSIBLE_AI_ENABLE_ROLE_GEN_ENDPOINT-config-key_31333
branch
from
67eadca to
dd70716
Compare
|
goneri
deleted the
goneri/settings-add-the-ANSIBLE_AI_ENABLE_ROLE_GEN_ENDPOINT-config-key_31333
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ANSIBLE_AI_ENABLE_ROLE_GEN_ENDPOINTto be able to enable roleGen when needed.This will later be enabled by default.