-
Notifications
You must be signed in to change notification settings - Fork 101
Allow disabling text colors #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks okay, though I'd question if it warrants a dedicated CLI arg- for most things we guard that kind of addition pretty carefully.
I'm also curious how hard it is to get the build output to include color codes- my worry is that having this option could set an expectation that we're going to also filter or otherwise force-disable generation of color codes from the build, which could be problematic.
Ack. I can remove that bit.
Not sure I catch what you mean here... |
|
@Shrews there's a corner case in Rich interpreting This resulted in us settling on an additional variable I'm wondering if this PR would benefit from also consulting that var. Also, here's how |
Allows control of when builder output text is colorized.
Honors the
NO_COLOR
andFORCE_COLOR
environment variables.Fixes #716