Add ability to treat Python requirement warnings as errors #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrews
added
needs_triage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** WIP ***
Since we removed the use of an outdated Python requirements parsing library and move to accepting requirements following the PEP508 standard, a bad requirement is no longer silently ignored and passed to
pip, which should error. However, a user may wish to catch the warning/error earlier in theintrospectphase (or via the CLI command).This change adds a new
--warning-is-erroroption on theintrospectcommand. It can be passed as a build arg (INTROSPECT_OPTS) in the EE to allow the user to turn allintrospectwarnings on non-PEP508 compliant entries (even those that may be valid when passed along topip) into errors.