Skip to content

Fix parenthesis order in notification message building exception handling #15837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

uber-dendy
Copy link

SUMMARY

This PR fixes an issue in the notification message rendering logic where an AttributeError was raised due to an incorrect method call on a list. Specifically, when formatting exception tracebacks for notifications, the code was attempting to call .replace() on the result of traceback.format_exception(), which returns a list rather than a string. This led to the following error:

msg = '\r\n'.join([e.message, ''.join(traceback.format_exception(None, e, e.__traceback__).replace('\n', '\r\n'))])
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'replace'
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

Signed-off-by: Yuriy Savinkin <[email protected]>
@AlanCoding AlanCoding changed the title Fix parenthesis order Fix parenthesis order in notification message building exception handling Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant