Remove Lightspeed Enabled setting #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
approved these changes
Feb 17, 2025
mabashian
force-pushed
the
mabashian/remove-lightspeed-enabled-checkbox
branch
from
f70d622 to
e4352ce
Compare
mabashian
force-pushed
the
mabashian/remove-lightspeed-enabled-checkbox
branch
from
e4352ce to
bd83ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://issues.redhat.com/browse/AAP-31064
The scope of the changes has shifted a bit after initial investigation. We realized that the "Lightspeed Enabled" checkbox was redundant with the user being logged in. The only "automatic" action that Lightspeed takes is code completion (which has it's own checkbox to toggle on/off). All other actions are manually initiated by the user by clicking buttons or executing commands. The fact that they're opting in by taking the action tells us that they actually want to perform that action. I've shifted some of the checks we used to have for "Lightspeed Enabled" to now check to make sure the user is actually logged in to Lightspeed before proceeding. This should simplify the user experience and simply the onboarding of Lightspeed users.
The other change here is defaulting the Ansible > Lightspeed > Suggestions checkbox to "enabled." The original intent behind the ticket was to programatically set this value to true whenever the user logged in to Lightspeed. In reality though, we only want to make sure that this value is set to true initially. Once the user turns it off, it should stay off. The easiest way to achieve this was to simply default the value to true on install. Of course, the suggestion completion won't trigger if the user is logged out of Lightspeed (see above).