AAP-39941: Migrate the role generation away from webpack #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
goneri/migrate-the-role-Gen-to-Vite_16259
branch
from
8995d08 to
77670c5
Compare
goneri
force-pushed
the
goneri/migrate-the-role-Gen-to-Vite_16259
branch
from
d51d309 to
737f018
Compare
goneri
force-pushed
the
goneri/migrate-the-role-Gen-to-Vite_16259
branch
from
737f018 to
94265ab
Compare
goneri
force-pushed
the
goneri/migrate-the-role-Gen-to-Vite_16259
branch
from
94265ab to
8d251bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Vite/Vue for this webview, as developers. This allows us to change the code and do live reloading without going through all the pain of Webpack.
Disable the syntax highlighting of the playbook generation because the library loading was not compatible. During the coming transition of playbook gen to Vite, we will reimplement this feature with
primevue, the same way it's now done for role Gen.This change slightly lowers the code coverage. We would like to step back and take a bit of time to implement the way we test these Webviews. We are thinking of a series of unit-test-ish (vitest) that focus on each component. This way we would use Selenium only to validate the happy path.