roleGen: properly reset the outline when they are changed manually #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user goes back to the first page, we need to ignore the `outline` used previously or we will mess up the next role generation request. - reset the request if the outline get changed - don't reset the outline if the user get back on page one - the outline and request will be reset only if the user changes the prompt - keep the prompt if the WCA answer has not prompt set - finally, if `selectionStart()` returns `undefined`, we default on `0`
…en-they-are-changed-manually_31765
mabashian
approved these changes
Feb 19, 2025
goneri
deleted the
goneri/roleGen-properly-reset-the-outline-when-they-are-changed-manually_31765
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user goes back to the first page, we need to ignore the
outlineusedpreviously or we will mess up the next role generation request.
selectionStart()returnsundefined, we default on0