-
Notifications
You must be signed in to change notification settings - Fork 6
feat: escape Markdown syntax in changelog titles #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
By the way, I keep having this, @klmcadams you might want to check.. maybe it is my python version though...
|
Kinda shocking we do not have the changelog action activated on the changelog repo hahhaha |
#690 only for you... 🙃 |
We dont want to be our own nightmare :D |
I know we already discussed about it in the past but we might want to extend the scope of |
You saying I'm special?..... mmmhhh..... special, I like that... |
I fully agree about this. Also, note that the changelog templates using Sphinx-design cards may suffer from rendering issues if symbols are included. Following @SMoraisAnsys suggestion, I would prefer to block the use of symbols rather than trying to escape them. This just adds more symbols to the fragment. |
So, shall we just close this and tackle a refactoring that does not support any kind of rich syntax? (neither MD, rST...) |
I agree with closing this PR. Note that it would be wise that the refactoring is compatible with |
Closing this after the discussion. |
It seems there is not way to check if Markdown syntax is correct or not (Ref: https://stackoverflow.com/questions/25331366/markdown-syntax-checking-for-continous-integration)
Hence I am going with a more humble approach.
Close #696