Skip to content

Store composite definitions in UserFiles directory #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

greschd
Copy link
Member

@greschd greschd commented Apr 16, 2025

In the PyMechanical integration, store the composite definitions H5 file in the UserFiles directory of the Mechanical project tree.
This matches the new behavior of Mechanical standalone (since 25R2), which expects it to be inside UserFiles.

With the combined changes, projects created with the PyACP / PyMechanical workflow can now be post-processed also within Mechanical directly.

In the PyMechanical integration, store the composite definitions
H5 file in the UserFiles directory of the Mechanical project
tree.
This matches the new behavior of Mechanical standalone (since 25R2),
which computes the path of this file relative to the UserFiles
directory (i.e., expects it to be inside UserFiles).

With the combined changes, projects created with the PyACP /
PyMechanical workflow can now be post-processed also within
Mechanical directly.
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.92%. Comparing base (5222628) to head (c6b93cd).

Files with missing lines Patch % Lines
...c/ansys/acp/core/mechanical_integration_helpers.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   94.91%   94.92%   +0.01%     
==========================================
  Files         109      109              
  Lines        5737     5736       -1     
  Branches      328      328              
==========================================
  Hits         5445     5445              
+ Misses        291      290       -1     
  Partials        1        1              
Flag Coverage Δ
direct-launch 91.43% <0.00%> (+0.01%) ⬆️
minimum-deps 93.08% <0.00%> (+0.01%) ⬆️
python-3.10 94.14% <0.00%> (+0.01%) ⬆️
python-3.11 94.07% <0.00%> (+0.01%) ⬆️
python-3.12 94.28% <0.00%> (+0.01%) ⬆️
server-2024R2 90.63% <0.00%> (+0.01%) ⬆️
server-2025R1 94.02% <0.00%> (+0.01%) ⬆️
server-2025R2 94.07% <0.00%> (+0.01%) ⬆️
server-latest 94.71% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant