Skip to content

Conversation

ompat5
Copy link
Collaborator

@ompat5 ompat5 commented Oct 7, 2025

  • Tree Payloads: Added validation to sanitize tree node values using bleach. If the sanitized value differs from the original, an error is raised.
  • Table Payloads: Added validation to sanitize string elements in table arrays using bleach.clean(). If the sanitized value differs from the original, an error is raised.
  • Environment Variable: Introduced the ADR_VALIDATION_BETAFLAG_ANSYS environment variable to enable or disable this feature. This ensures the changes are only active for testing purposes and do not impact end users.

Added input validation for Trees and Tables in our set payload methods using bleach.
@ompat5 ompat5 requested a review from margalva October 7, 2025 17:29
@ompat5 ompat5 self-assigned this Oct 7, 2025
@ompat5 ompat5 requested a review from viseshrp as a code owner October 7, 2025 17:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.59%. Comparing base (b353903) to head (ead9c1f).

Files with missing lines Patch % Lines
...nsys/dynamicreporting/core/utils/report_objects.py 53.33% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   81.65%   81.59%   -0.06%     
==========================================
  Files          28       28              
  Lines        7975     7989      +14     
  Branches     1466     1474       +8     
==========================================
+ Hits         6512     6519       +7     
- Misses        996     1001       +5     
- Partials      467      469       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ompat5 ompat5 requested a review from viseshrp October 15, 2025 16:08
@ompat5 ompat5 merged commit 7d00d0f into main Oct 15, 2025
17 checks passed
@ompat5 ompat5 deleted the om/payload_input_validation branch October 15, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants