Skip to content

FIX: Fix bug #1328 #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

svandenb-dev
Copy link
Collaborator

This PR is fixing bug #1328

closes #1328

@svandenb-dev svandenb-dev self-assigned this Jul 4, 2025
@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Jul 4, 2025
@svandenb-dev svandenb-dev requested a review from nefelimet July 4, 2025 13:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.17%. Comparing base (c4000b2) to head (5054212).
Report is 3 commits behind head on main.

❌ Your patch status has failed because the patch coverage (71.42%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1330   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files         162      162           
  Lines       23782    23785    +3     
=======================================
+ Hits        18115    18118    +3     
  Misses       5667     5667           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nefelimet
nefelimet previously approved these changes Jul 7, 2025
Copy link
Collaborator

@nefelimet nefelimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bug is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_primitive_by_layer_and_point doesn't identify any primitive when nets argument is not given
3 participants