FEAT: DC settings

[gkorompi]

No description provided.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.28%. Comparing base (d256bb9) to head (d290b03).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
+ Coverage   76.17%   76.28%   +0.10%     
==========================================
  Files         162      162              
  Lines       23806    23812       +6     
==========================================
+ Hits        18135    18165      +30     
+ Misses       5671     5647      -24     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hui-zhou-a]

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

[gkorompi]

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

Hello @hui-zhou-a i think this is in SiwaveDCSimulationSetup class, we need it in SiwaveSimulationSetup too

[hui-zhou-a]

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

Hello @hui-zhou-a i think this is in SiwaveDCSimulationSetup class, we need it in SiwaveSimulationSetup too

Can you explain why you need

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

Hello @hui-zhou-a i think this is in SiwaveDCSimulationSetup class, we need it in SiwaveSimulationSetup too

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

Hello @hui-zhou-a i think this is in SiwaveDCSimulationSetup class, we need it in SiwaveSimulationSetup too

Can you explain why you need it under SiwaveSimulationSetup?

[gkorompi]

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

Hello @hui-zhou-a i think this is in SiwaveDCSimulationSetup class, we need it in SiwaveSimulationSetup too

Can you explain why you need

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

Hello @hui-zhou-a i think this is in SiwaveDCSimulationSetup class, we need it in SiwaveSimulationSetup too

dc_advanced_settings It is already in there.

pyedb/src/pyedb/dotnet/database/utilities/siwave_simulation_setup.py

Line 365 in c6ebb4a

def dc_advanced_settings(self):

Hello @hui-zhou-a i think this is in SiwaveDCSimulationSetup class, we need it in SiwaveSimulationSetup too

Can you explain why you need it under SiwaveSimulationSetup?

Those options exist in syz setups too:

[svandenb-dev]

LGTM

[hui-zhou-a]

@svandenb-dev @gkorompi revert to GK's commit as changing code structure is not that simple. Lots of test are failing.

[svandenb-dev]

LGTM

[svandenb-dev]

LGTM

[svandenb-dev]

LGTM

Done already