FIX: Improve grpc tests #1392
Merged
FIX: Improve grpc tests #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/system/test_edb.py # tests/system/test_edb_components.py # tests/system/test_edb_configuration_2p0.py
For more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
- Coverage 50.02% 49.68% -0.34%
==========================================
Files 251 251
Lines 37837 37945 +108
==========================================
- Hits 18927 18853 -74
- Misses 18910 19092 +182 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the gRPC tests for the EDB (Electronic Design Database) testing framework by modifying the close() method calls to explicitly disable RPC session termination. The change ensures that test environments maintain better control over gRPC session lifecycle management and prevents potential cleanup issues during test execution.
- Updates all
edb.close()calls to useedb.close(terminate_rpc_session=False)parameter - Adds proper test cleanup handling for gRPC sessions in configuration tests
- Includes minor API parameter name standardization in source excitation methods
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_edb.py | Updates close() calls to prevent RPC session termination |
| tests/system/test_edb_*.py | Systematically updates all test files to use non-terminating close() calls |
| src/pyedb/grpc/database/source_excitations.py | Standardizes parameter names and adds new port creation options |
| src/pyedb/grpc/database/simulation_setup/siwave_simulation_setup.py | Adds property accessors and improves sweep method return values |
| src/pyedb/grpc/database/hierarchy/component.py | Enhances package definition creation with component part name support |
| src/pyedb/grpc/database/components.py | Adds new port creation method for RLC components |
| src/pyedb/dotnet/edb.py | Updates close() method signature to accept keyword arguments |
| src/pyedb/dotnet/database/sim_setup_data/io/siwave.py | Adds deprecated property and standardizes mesh property naming |
Comments suppressed due to low confidence (2)
tests/system/test_edb_configuration_2p0.py:145
- There are two test methods with identical names 'test_13b_stackup_materials'. The second one should have a unique name to avoid conflicts.
def test_13b_stackup_materials(self, edb_examples):
tests/system/test_edb_configuration_2p0.py:1518
- There are two test methods with identical names 'test_08a_operations_cutout'. The second one should have a unique name to avoid conflicts.
def test_08a_operations_cutout(self, edb_examples):
Co-authored-by: Copilot <[email protected]>
For more information, see https://pre-commit.ci
…_grpc_tests # Conflicts: # src/pyedb/grpc/database/utility/value.py
github-actions
bot
added
the
grpc-transition
For more information, see https://pre-commit.ci
# Conflicts: # tests/system/test_edb_modeler.py
For more information, see https://pre-commit.ci
# Conflicts: # tests/system/test_edb_configuration_2p0.py
For more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.