fix: 修复useActive 中 items 为空数组导致的异常 #824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Walkthrough""" Walkthrough本次更改在 Changes
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Walkthrough: 该PR修复了在 Changes:
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
components/suggestion/useActive.ts
Outdated
| @@ -117,6 +117,7 @@ export default function useActive( | |||
| }); | |||
|
|
|||
| React.useEffect(() => { | |||
| if(items?.length === 0) return; | |||
There was a problem hiding this comment.
添加了对items为空数组的检查，确保在items为空时提前返回，避免后续对空数组的操作。这是一个重要的修复，防止了潜在的运行时错误。
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/suggestion/useActive.ts (1)
119-124: 逻辑修复正确，防止了空数组导致的异常修改增加了一个守卫条件，当
items为空数组或未定义时直接返回，避免了在items为空时访问items[0].value导致的类型错误。这是一个必要的防御性编程措施。不过有一点小建议：可以考虑使用
if (!items?.length)作为条件判断，这样更简洁，且同样能处理items为undefined/null的情况。- if(items?.length === 0) return; + if (!items?.length) return;
|
使用当中存在错误，直接导致崩溃 |
afc163
reviewed
May 14, 2025
Comment on lines
+120
to
124
| // 确保 items 是一个数组且至少有一个元素 | ||
| if (!Array.isArray(items) || items.length === 0) return; | ||
| if (open) { | ||
| setActivePaths([items[0].value]); | ||
| } |
There was a problem hiding this comment.
Suggested change
| // 确保 items 是一个数组且至少有一个元素 | |
| if (!Array.isArray(items) || items.length === 0) return; | |
| if (open) { | |
| setActivePaths([items[0].value]); | |
| } | |
| if (open && Array.isArray(items) && items.length > 0) { | |
| setActivePaths([items[0].value]); | |
| } |
|
补充一个测试用例吧。 |
Bundle ReportChanges will increase total bundle size by 232.88kB (171.19%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antdx-array-pushAssets Changed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit