Skip to content

add spdlog to the deps of mockimpl #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented May 29, 2025

fixes: #774

@wxyucs wxyucs requested a review from jiaweizone as a code owner May 29, 2025 03:01
@wxyucs wxyucs added kind/bug Something isn't working version/0.15 labels May 29, 2025
@wxyucs wxyucs requested a review from LHT129 May 29, 2025 03:06
Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ Your project check has failed because the head coverage (88.81%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   88.75%   88.81%   +0.06%     
==========================================
  Files         198      198              
  Lines       12529    12529              
==========================================
+ Hits        11120    11128       +8     
+ Misses       1409     1401       -8     
Flag Coverage Δ
cpp 88.81% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.51% <ø> (ø)
datacell 91.71% <ø> (+0.03%) ⬆️
index 88.74% <ø> (+0.09%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdfd67...e5f5926. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wxyucs wxyucs force-pushed the fix-spdlog-dep-missing branch from 348dc91 to 7aa81f7 Compare May 29, 2025 07:18
@wxyucs wxyucs self-assigned this May 29, 2025
@wxyucs wxyucs force-pushed the fix-spdlog-dep-missing branch from 7aa81f7 to e5f5926 Compare May 30, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS version/0.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: spdlog/spdlog.h: No such file or directory
2 participants