Add --new-session and --die-with-parent flags to bubblewrap #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security improvements: - --new-session: Protects against CVE-2017-5226 (TIOCSTI terminal injection) by calling setsid() to disconnect from the controlling terminal - --die-with-parent: Ensures all sandbox processes are killed (via SIGKILL) when bwrap's parent dies, preventing orphan processes Both flags are used by Flatpak in production and work correctly with our existing --unshare-pid flag (required for --die-with-parent to kill all descendant processes). Added regression tests to verify: - Child processes are killed when sandbox is terminated via timeout - No orphan processes remain after forced termination 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ollie-anthropic
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--new-sessionflag to bwrap invocations for improved terminal isolation--die-with-parentflag to ensure sandbox processes are properly terminated when the parent diesThese flags are used by Flatpak in production and work correctly with our existing
--unshare-pidflag.Changes
--new-session: Callssetsid()to create a new terminal session, disconnecting the sandbox from the controlling terminal--die-with-parent: Ensures all sandbox processes are killed (via SIGKILL) when bwrap's parent dies, preventing orphan processesTest plan
🤖 Generated with Claude Code