Skip to content

fix: flaky payment-details test with Stripe iframe waits #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahitya-chandra wants to merge 3 commits into from
Closed

fix: flaky payment-details test with Stripe iframe waits #1584

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
513f576
fix: flaky payment-details test with Stripe iframe waits
sahitya-chandra Jan 30, 2026
fdbba34
Merge branch 'main' into fix-payment-details-flaky-test
sahitya-chandra Jan 30, 2026
29dffc1
Merge branch 'main' into fix-payment-details-flaky-test
sahitya-chandra Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/tests/settings/administrator/payment-details.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ test.describe("Company administrator settings - payment details", () => {

await withinModal(
async () => {
await expect(stripePaymentFrame.getByLabel("Test Institution")).toBeVisible();
await stripePaymentFrame.getByLabel("Test Institution").click();
await stripeBankFrame.getByTestId("agree-button").click();
await stripeBankFrame.getByTestId("success").click();
Expand All @@ -62,6 +63,7 @@ test.describe("Company administrator settings - payment details", () => {
await page.getByRole("button", { name: "Edit" }).click();
await withinModal(
async () => {
await expect(stripePaymentFrame.getByLabel("Test Institution")).toBeVisible();
await stripePaymentFrame.getByLabel("Test Institution").click();
await stripeBankFrame.getByTestId("agree-button").click();
await stripeBankFrame.getByTestId("high balance").click();
Expand Down