Open
Conversation
nyomanjyotisa
commented
Feb 5, 2026
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftColumn[0].f1_28[0]" => normalized_tax_field(billing_entity_name), | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftColumn[0].f1_29[0]" => country_code, | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftColumn[0].f1_30[0]" => normalized_street_address, | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].RightColumn[0].f1_31[0]" => normalized_tax_field(full_city_address), |
Member
Author
There was a problem hiding this comment.
On the new template LeftCol changed to LeftColumn and RightCol changed to RightColumn. And f1_31 moved from LeftColumn to RightColumn
|
|
||
| class TaxDocuments::Form1099necSerializer < TaxDocuments::BaseSerializer | ||
| TAX_FORM_COPIES = %w[A 1 B 2 C].freeze | ||
| TAX_FORM_COPIES = %w[A 1 B 2].freeze |
Member
Author
There was a problem hiding this comment.
Copy C no longer exist
| "topmostSubform[0].Copy#{tax_form_copy}[0].LeftCol[0].f#{page_number}_7[0]" => normalized_tax_field(full_city_address), | ||
| # Nonemployee compensation | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].RightColumn[0].f#{page_number}_9[0]" => compensation_amount_for_tax_year(tax_year), | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].RightCol[0].f#{page_number}_9[0]" => compensation_amount_for_tax_year(tax_year), |
Member
Author
There was a problem hiding this comment.
LeftColumn changed to LeftCol and RightColumn changed to RightCol
|
|
||
| private | ||
| def header_for(tax_form_copy) | ||
| case tax_form_copy |
Member
Author
There was a problem hiding this comment.
header_for method no longer needed, all copies now use PgHeader
nyomanjyotisa
commented
Feb 6, 2026
|
|
||
| result = { | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].Copy#{tax_form_copy}Header[0].CalendarYear[0].f#{page_number}_1[0]" => formatted_tax_year, | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].CopyHeader[0].CalendarYear[0].f#{page_number}_1[0]" => tax_year.to_s, |
Member
Author
There was a problem hiding this comment.
Previously we still use the 2023 serializer which the template already has 20 prefix and the label was changed since 2024 template (this still the latest template)
2023:
2025, Before:
2025, After fix:
|
|
||
| { | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].#{header_for(tax_form_copy)}Header[0].CalendarYear[0].f#{page_number}_1[0]" => tax_year.to_s.last(2), | ||
| "topmostSubform[0].Copy#{tax_form_copy}[0].PgHeader[0].CalendarYear[0].f#{page_number}_1[0]" => tax_year.to_s, |
Member
Author
There was a problem hiding this comment.
2023:
2025, before:
2025, after:
Member
|
ershad
approved these changes
Feb 6, 2026
Member
Author
|
@ershad _a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://chat.google.com/room/AAQAWojMDVI/cvwCBw-61Yo/030bMO0dPdk?cls=10
Description
Update tax form PDF templates to 2025 versions and update serializer code to match the new field naming conventions
Problem
The 1042-S and 1099-NEC PDF templates were outdated (2024 versions). The IRS releases new versions of these forms each tax year with updated templates
We don't show "For calendar year" for 1099-DIV, and wrong year format on 1099-NEC
Solution
Updated the 1042-S and 1099-NEC PDF templates to their 2025 versions and modified the corresponding serializers to match the new field naming conventions. 1099-DIV not updated since the current template already the latest template, see https://www.irs.gov/forms-pubs/about-form-1099-div
Updated the "For calendar year" serializer for 1099-DIV and 1099-DEV
Before/After
Before
After
1042-S
1099-NEC
1099-DIV
AI Disclosure
Claude Opus 4.5 for code generation, all code self reviewed.