Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1531
Description
Problem
The test complete-flow spec was flaky because it used broad page.locator("tbody") selectors to check table content. When multiple invoice rows were present, the date Dec 1, 2024 was being truncated to Dec 1, 202 due to CSS text overflow in table cells, causing the assertion to fail
Solution
Changed from broad tbody selectors to row-specific selectors using
page.locator("tbody tr").filter({ hasText: "CUSTOM-X" }). This ensures assertions are targeted to the specific invoice row, avoiding issues with text truncation across the entire table body.Test Results
Tested with --repeat-each=20 --workers=1 - all 20 test runs passed
Checklist
AI Disclosure
Used Claude Opus 4.5 to understand the issue and implement the fix. Code was reviewed and tested manually