Make investment_amount_cents NOT NULL on dividends#1612
Open
nyomanjyotisa wants to merge 1 commit intomainfrom
Open
Make investment_amount_cents NOT NULL on dividends#1612nyomanjyotisa wants to merge 1 commit intomainfrom
nyomanjyotisa wants to merge 1 commit intomainfrom
Conversation
nyomanjyotisa
commented
Feb 12, 2026
| }), | ||
| ] | ||
| : []), | ||
| columnHelper.accessor("investmentAmountCents", { |
Member
Author
There was a problem hiding this comment.
Make investment amount column always visible since investment_amount_cents is now NOT NULL
| "investmentAmountCents", | ||
| "Investment amount", | ||
| (value) => (value ? formatMoneyFromCents(value) : "N/A"), | ||
| (value) => formatMoneyFromCents(value), |
Member
Author
There was a problem hiding this comment.
Remove null fallback since investment_amount_cents is now NOT NULL
Member
Author
|
@ershad Could you help to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Wait for both #1611 and #1610 merged and executed before merging this PR
Issue: #1596
Description
Enforce
investment_amount_centsas a required field on dividends by adding a NOT NULL constraint, model validation, and updating the frontend to always display the investment amount column.Before/After
No UI changes
AI Disclosure
Claude Opus 4.6 for code generation. All code self reviewed.