Skip to content

fix video autoplay && image styles #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix video autoplay && image styles #196

wants to merge 1 commit into from

Conversation

radeanu
Copy link

@radeanu radeanu commented Jun 27, 2023 •
edited
Loading

  1. Removed invalid width="100%" and height="100%" attributes from video
  2. Added 100% height and width to .vueperslide__video class
  3. Added backgroundRepeat: 'no-repeat' style to image
  4. Fixed video autoplay bug on slide navigation, see Carousel with Images plus videos not stopping autoplay #174
  5. Fixed bug when loading component is still visible with lazy and video

@radeanu radeanu marked this pull request as draft July 6, 2023 04:22
@radeanu radeanu closed this Jul 6, 2023
@radeanu radeanu reopened this Jul 6, 2023
@radeanu radeanu marked this pull request as ready for review July 6, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radeanu