Skip to content

libgccjit: Support more target builtin types #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libgccjit: Support more target builtin types #20

wants to merge 1 commit into from

Conversation

antoyo
Copy link
Owner

@antoyo antoyo commented Dec 5, 2024 •
edited
Loading

This also adds option to abort on unsupported type in order to be able
to detect new unsupported types more easily.

gcc/jit/ChangeLog:
PR jit/117886
* dummy-frontend.cc (jit_abort_on_unsupported_target_builtin):
New variable
* libgccjit.cc (jit_abort_on_unsupported_target_builtin): New
variable.
(gcc_jit_set_abort_on_unsupported_target_builtin): New function.
* libgccjit.h (gcc_jit_set_abort_on_unsupported_target_builtin):
New function.
* libgccjit.map (LIBGCCJIT_ABI_35): New ABI tag.
* docs/topics/compatibility.rst (LIBGCCJIT_ABI_35): New ABI tag.
* docs/topics/contexts.rst: Document new function.

@antoyo antoyo added the waiting for review Waiting for review from upstream libgccjit maintainer label Dec 5, 2024
davidmalcolm
davidmalcolm reviewed Dec 14, 2024
View reviewed changes
@davidmalcolm davidmalcolm added waiting on author and removed waiting for review Waiting for review from upstream libgccjit maintainer labels Dec 14, 2024
@antoyo antoyo added waiting for review Waiting for review from upstream libgccjit maintainer and removed waiting on author labels Dec 15, 2024
@antoyo antoyo force-pushed the fix/target-crash branch from 4ea0377 to 66ac520 Compare March 18, 2025 16:53
@antoyo antoyo force-pushed the fix/target-crash branch 2 times, most recently from 4250712 to 0ab4b82 Compare March 29, 2025 00:58
@antoyo antoyo changed the title libgccjit: Fix crash on some targets libgccjit: Support more target builtin types Mar 29, 2025
@antoyo antoyo force-pushed the fix/target-crash branch from 0ab4b82 to 7ee7aa7 Compare March 29, 2025 01:03
davidmalcolm
davidmalcolm requested changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@davidmalcolm davidmalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be gcc_jit_context_set_abort_on_unsupported_target_builtin and be a property of the context, rather than a global; you can get the gcc::jit::active_playback_ctxt and from that the corresponding recording ctxt.

@davidmalcolm davidmalcolm added waiting on author and removed waiting for review Waiting for review from upstream libgccjit maintainer labels Apr 1, 2025
@antoyo
libgccjit: Support more target builtin types
6beff8e 
This also adds option to abort on unsupported type in order to be able
to detect new unsupported types more easily.

gcc/jit/ChangeLog:
	PR jit/117886
	* dummy-frontend.cc: Support some missing types.
	* jit-playback.h (get_abort_on_unsupported_target_builtin): New
	function.
	* jit-recording.cc (get_abort_on_unsupported_target_builtin,
	set_abort_on_unsupported_target_builtin): New functions.
	* jit-recording.h (get_abort_on_unsupported_target_builtin,
	set_abort_on_unsupported_target_builtin): New functions.
	(m_abort_on_unsupported_target_builtin): New field.
	* libgccjit.cc
	(gcc_jit_context_set_abort_on_unsupported_target_builtin): New
	function.
	* libgccjit.h
	(gcc_jit_context_set_abort_on_unsupported_target_builtin): New
	function.
	* libgccjit.map (LIBGCCJIT_ABI_35): New ABI tag.
	* docs/topics/compatibility.rst (LIBGCCJIT_ABI_35): New ABI tag.
	* docs/topics/contexts.rst: Document new function.
@antoyo antoyo force-pushed the fix/target-crash branch from 7ee7aa7 to 6beff8e Compare April 3, 2025 23:34
@antoyo
Copy link
Owner Author

antoyo commented Apr 3, 2025

This should be gcc_jit_context_set_abort_on_unsupported_target_builtin and be a property of the context, rather than a global; you can get the gcc::jit::active_playback_ctxt and from that the corresponding recording ctxt.

I edited the patch to do this.
Would this be OK to merge now or is it better to wait for stage 1?
Thanks for the review!

@antoyo antoyo added waiting for review Waiting for review from upstream libgccjit maintainer and removed waiting on author labels Apr 3, 2025
@antoyo antoyo requested a review from davidmalcolm April 3, 2025 23:37
davidmalcolm
davidmalcolm approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@davidmalcolm davidmalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated patch. Looks good to me. Might require Darwin-specific updates (the .map format doesn't work there, IIRC).

Can this wait until GCC 16, or is this important to rustc_codegen_gcc?

@davidmalcolm davidmalcolm added ready to merge and removed waiting for review Waiting for review from upstream libgccjit maintainer labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmalcolm davidmalcolm davidmalcolm approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoyo @davidmalcolm