Added timer to the stream outbound function in case ovs stops responding. #31
Conversation
util/stream.go
Outdated
| } | ||
|
|
||
| klog.V(4).InfoS("Sent", "dataLength", len(data), "data", len(data), data) | ||
| case <-time.After(messageTimeout): |
There was a problem hiding this comment.
Question: If we add timeout control in MessageStream outbound functions, do we need other similar control in ofnet?
There was a problem hiding this comment.
This may cause the connnection unstable if no message is sent in "messageTimeout"?
There was a problem hiding this comment.
Maybe you meant this?
for {
select {
case <-m.Shutdown:
klog.Infof("Closing OpenFlow message stream.")
m.conn.Close()
close(m.parserShutdown)
return
case msg := <-m.Outbound:
// Forward outbound messages to conn
data, _ := msg.MarshalBinary()
writeErrorCh := make(chan error)
go func() {
_, err := m.conn.Write(data)
writeErrorCh<-err
}()
select {
case err := <-writeErrorCh:
if err != nil {
klog.ErrorS(err, "OutboundError")
m.Error <- err
m.Shutdown <- true
} else {
klog.V(4).InfoS("Sent", "dataLength", len(data), "data", len(data), data)
}
case <-time.After(messageTimeout):
m.Error <- errors.New("Write to socket timed out")
m.Shutdown <- true
}
close(writeErrorCh)
}
There was a problem hiding this comment.
My bad, put the timer under wrong scope. Would fix this.
There was a problem hiding this comment.
To your question:
Question: If we add timeout control in MessageStream outbound functions, do we need other similar control in ofnet?
No we should not have any timer in the ofnet code. ofnet code should either get a success or an error and should not expect libopenflow/stream code to block indefinitely.
Having an offline discussion with @ashish-varma, no better solution is found. Would you give some suggestions @tnqn @antoninbas |
I had the same question as @wenyingd, and I don't see an answer here yet. Why can't we use |
It make more sense to use SetWriteDeadline. I am testing the code with this and update the commit. |
in case ovs stops responding. Fixed naming of some of the variables to more appropriate names. Signed-off-by: Ashish Varma <[email protected]>
|
@antoninbas @tnqn Do you have other comments on this change? |
| case msg := <-m.Outbound: | ||
| // Forward outbound messages to conn | ||
| data, _ := msg.MarshalBinary() | ||
| m.conn.SetWriteDeadline(time.Now().Add(messageTimeout)) |
There was a problem hiding this comment.
nit: maybe we should handle the error return value here?
4 participants
Fixed naming of some of the variables to more appropriate names.