fix: render error when double click legend #6767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -218,7 +234,7 @@ function oneToOne( | |||
| } | |||
|
|
|||
| // No need to apply animation since fromPath equals toPath. | |||
| return null; | |||
| return pathShape.animate(keyframes, timeEffect); | |||
There was a problem hiding this comment.
这里修改后，原来没有动画的场景也会应用动画，这部分会有影响吗，交互频繁的时候性能会下降吗
There was a problem hiding this comment.
那就做一下判断？如果 from 关键帧和 to 关键帧 不同再进行动画？🤔 我试试
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
__removed__判断是否需要被移除，比如说在 exitFunction 动画执行时，如果发生了 update 事件，就会把__removed__设置为 false，移除事件就不会发生了。