fix: throw error when render edge without terminal (#3331)

antvis · Mar 2, 2023 · a1d8642 · a1d8642
1 parent 309b5a7
commit a1d8642
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/packages/x6/package.json b/packages/x6/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/x6",
-  "version": "2.5.1",
+  "version": "2.6.1",
   "description": "JavaScript diagramming library that uses SVG and HTML for rendering",
   "main": "lib/index.js",
   "module": "es/index.js",

diff --git a/packages/x6/src/renderer/queueJob.ts b/packages/x6/src/renderer/queueJob.ts
@@ -46,11 +46,7 @@ export class JobQueue {
 
     let job
     while ((job = this.queue.shift())) {
-      try {
-        job.cb()
-      } catch (error) {
-        // pass
-      }
+      job.cb()
       if (this.getCurrentTime() - startTime >= this.frameInterval) {
         break
       }

diff --git a/packages/x6/src/renderer/scheduler.ts b/packages/x6/src/renderer/scheduler.ts
@@ -202,7 +202,7 @@ export class Scheduler extends Disposable {
     }
 
     let result = 0
-    if (this.isInRenderArea(view)) {
+    if (this.isUpdateable(view)) {
       result = this.updateView(view, flag, options)
       viewItem.flag = result
     } else {
@@ -479,11 +479,11 @@ export class Scheduler extends Disposable {
     return effectedEdges
   }
 
-  protected isInRenderArea(view: CellView) {
-    if (!this.renderArea) {
-      return true
-    }
+  protected isUpdateable(view: CellView) {
     if (view.isNodeView()) {
+      if (!this.renderArea) {
+        return true
+      }
       const node = view.cell
       return this.renderArea.isIntersectWithRect(node.getBBox())
     }