chore(layout): d3 force and d3 force 3d layout

[yvonneyx]

Checklist

• High-quality implementation
• Unit tests
• API documentation

[gemini-code-assist]

Summary of Changes

Hello @yvonneyx, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the layout options by integrating a new D3 force-directed graph layout. It includes the necessary data and demonstration files to showcase its functionality. The underlying implementation has been refactored to align with the existing layout architecture, ensuring consistency and maintainability. This change provides more flexibility in visualizing complex graph structures.

Highlights

• New D3 Force Layout: Introduced a new D3 force-directed graph layout, enhancing the library's layout capabilities.
• Dataset and Demo Additions: Added new JSON datasets (d3-force.json, relations.json) and a corresponding demo file (d3-force.ts) for the new layout.
• Layout Refactoring: Refactored the D3ForceLayout implementation to extend BaseLayoutWithIterations, improving its integration with the base layout system and internal management of D3 nodes and edges.
• Test Updates: Updated unit tests for D3 force layout, including new test cases for viewport constraints, fixed node positions, and general configuration. Old snapshot SVG files were removed.
• Configuration Handling: Modified BaseLayout to use deepMix for merging options, ensuring more robust configuration management.
• Edge ID Generation: Improved the getEdgeId utility to handle cases where edge IDs are not explicitly provided, generating unique IDs by appending a counter for duplicates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the d3-force layout and includes a significant refactoring of the layout's implementation and tests. The new D3ForceLayout extends a base class, which improves code structure. The tests have been rewritten to be more robust and clear. I've found a couple of issues: a minor one is a copy-paste error in a demo file's UI, and a more important one is related to a global counter for edge ID generation that is not being reset, which could lead to non-deterministic behavior in applications using multiple layouts. Apart from these points, the changes are solid and a good improvement.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 95.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.04%. Comparing base (ffacdc4) to head (b438141).

Files with missing lines	Patch %	Lines
packages/layout/src/d3-force/index.ts	94.11%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               v5     #266      +/-   ##
==========================================
+ Coverage   80.72%   81.04%   +0.32%     
==========================================
  Files          70       69       -1     
  Lines        4928     4954      +26     
  Branches     1214     1222       +8     
==========================================
+ Hits         3978     4015      +37     
+ Misses        948      853      -95     
- Partials        2       86      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.